Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update the zip GA to manual triggers and exclude unnecessary files #76

Merged
merged 1 commit into from
Jun 7, 2024
Merged

chore: update the zip GA to manual triggers and exclude unnecessary files #76

merged 1 commit into from
Jun 7, 2024

Conversation

MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Jun 6, 2024 •
edited
Loading

Description

This PR edit the zip generation GA to exclude unnecessary files and allow manual triggers.

Related: #74 #73

Excluded files: .git .* /test/* /requirements/* /docs/* composer.* *.yaml *.xml Makefile
For composer requirements, we have the --no-dev flag.

Extra information

Example of files not allowed (from #74 #73 ):

development tools
unneeded vendor folders for production (bower, node, grunt, etc)
demos
unit tests
08_18-10-54_openedx-commerce/vendor/nikic/php-parser
08_18-10-54_openedx-commerce/vendor/phar-io/manifest/.github
08_18-10-54_openedx-commerce/vendor/phpunit
08_18-10-54_openedx-commerce/vendor/myclabs/deep-copy/.github
08_18-10-54_openedx-commerce/vendor/phpunit/phpunit
08_18-10-54_openedx-commerce/vendor/phpunit/phpunit/src/TextUI/XmlConfiguration/PHPUnit
08_18-10-54_openedx-commerce/requirements/[pip.in](http://pip.in/)
08_18-10-54_openedx-commerce/requirements/[docs.in](http://docs.in/)
08_18-10-54_openedx-commerce/docs/make.bat
08_18-10-54_openedx-commerce/vendor/bin/phpunit
08_18-10-54_openedx-commerce/docs/source/conf.py
08_18-10-54_openedx-commerce/requirements/[pip-tools.in](http://pip-tools.in/)
08_18-10-54_openedx-commerce/vendor/bin/php-parse

After the change

The zip generated is:
openedx-commerce.zip

Openedx-commerce content:
Screenshot from 2024-06-06 13-04-19

Vendor directory:
Screenshot from 2024-06-06 13-08-35

Checklist for Merge

  • Tested in a remote environment
  • Rebased master/main
  • Squashed commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @MaferMazu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@MaferMazu MaferMazu requested review from feanil and felipemontoya June 6, 2024 12:12
This was linked to issues Jun 6, 2024
["BUG"] Not permitted files #73
Closed
["BUG"] Included Unneeded Folders #74
Closed
@MaferMazu MaferMazu force-pushed the mfmz/zip-exclusion branch from 8e8f0ee to f8b55bc Compare June 6, 2024 12:18
@MaferMazu MaferMazu changed the title ci: update the zip GA to manual triggers and exclude unnecessary files chore: update the zip GA to manual triggers and exclude unnecessary files Jun 6, 2024
felipemontoya
felipemontoya approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the dev artifacts looks very reasonable.

Have you tested the new generated zip to make sure it works as before?

@MaferMazu
Copy link
Contributor Author

Yes, @felipemontoya, I tested it, and it is our stage. I will proceed to merge this.

@MaferMazu MaferMazu merged commit 73a360f into openedx:main Jun 7, 2024
4 checks passed
@openedx-webhooks
Copy link

@MaferMazu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

This was referenced Jun 25, 2024
Closed
Merged
@MaferMazu MaferMazu mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemontoya felipemontoya felipemontoya approved these changes

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

["BUG"] Included Unneeded Folders ["BUG"] Not permitted files
4 participants
@MaferMazu @openedx-webhooks @feanil @felipemontoya